Merge pull request #906 from redhat-developer/refactor-yaml-recommend…

…ation-flag

renamed yaml.extension.recommendations

README.md

@@ -65,6 +65,7 @@ The following settings are supported:
 - `yaml.style.flowMapping` : Forbids flow style mappings if set to `forbid`
 - `yaml.style.flowSequence` : Forbids flow style sequences if set to `forbid`
 - `yaml.keyOrdering` : Enforces alphabetical ordering of keys in mappings when set to `true`. Default is `false`
+- `yaml.extension.recommendations` : Enable extension recommendations for YAML files. Default is `true`
 
 ## Adding custom tags
 

package.json

@@ -219,7 +219,7 @@
           "default": false,
           "description": "Enforces alphabetical ordering of keys in mappings when set to true"
         },
-        "yaml.recommendations.show": {
+        "yaml.extension.recommendations": {
           "type": "boolean",
           "default": "true",
           "description": "Suggest additional extensions based on YAML usage."

src/recommendation/openShiftToolkit.ts

@@ -13,7 +13,7 @@ import { IHandler } from './handler';
 const EXTENSION_NAME = 'redhat.vscode-openshift-connector';
 const GH_ORG_URL = `https://github.com/redhat-developer/vscode-openshift-tools`;
 const RECOMMENDATION_MESSAGE = `The workspace has a devfile.yaml. Install [OpenShift Toolkit](${GH_ORG_URL}) extension for assistance with deploying to a cluster?`;
-const YAML_RECOMMENDATIONS_SHOW = 'yaml.recommendations.show';
+const YAML_EXTENSION_RECOMMENDATIONS = 'yaml.extension.recommendations';
 
 function isDevfileYAML(uri: vscode.Uri): boolean {
   try {
@@ -28,7 +28,7 @@ function isDevfileYAML(uri: vscode.Uri): boolean {
 }
 
 export function initializeRecommendation(context: vscode.ExtensionContext, handler: IHandler): void {
-  const show = vscode.workspace.getConfiguration().get(YAML_RECOMMENDATIONS_SHOW);
+  const show = vscode.workspace.getConfiguration().get(YAML_EXTENSION_RECOMMENDATIONS);
   if (!show) {
     return;
   }