Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Msivasubramaniaan patch 1 #900

Merged
merged 3 commits into from Mar 14, 2023
Merged

Conversation

msivasubramaniaan
Copy link
Contributor

What does this PR do?

Added null check

What issues does this PR fix or reference?

Cannot read properties of undefined (reading 'findIndex')

Is it tested? How?

Yes

src/recommendation/openShiftToolkit.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msivasubramaniaan msivasubramaniaan merged commit c395794 into main Mar 14, 2023
@msivasubramaniaan msivasubramaniaan deleted the msivasubramaniaan-patch-1 branch March 14, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants