Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed proxy support #921

Merged
merged 1 commit into from May 25, 2023
Merged

Fixed proxy support #921

merged 1 commit into from May 25, 2023

Conversation

dmilosz
Copy link
Contributor

@dmilosz dmilosz commented Apr 15, 2023 •
edited

What does this PR do?

  • Correctly reads proxy settings from vscode user settings

What issues does this PR fix or reference?

#920
#694

Is it tested? How?

Tested manually by providing many proxy combinations.
Test steps:

  • In vscode, open user settings tab: F1 -> Preferences: Open User Settings -> Application -> Proxy
  • Pick Proxy Support to one of on, fallback, override
  • Write your specific proxy address, which is different than the one in HTTP_PROXY or HTTPS_PROXY environment variables.
  • Try to access resource which is only available when using the proxy.

@ksathyanm
Copy link

@msivasubramaniaan Can you please review this PR?

gorkem
gorkem reviewed May 25, 2023
View reviewed changes
Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gorkem gorkem merged commit b72e1b7 into redhat-developer:main May 25, 2023
3 checks passed
@gorkem
Copy link
Collaborator

gorkem commented May 25, 2023

Thank you for the PR @dmilosz. Sorry, it took a while for us to get to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gorkem gorkem gorkem approved these changes

@msivasubramaniaan msivasubramaniaan Awaiting requested review from msivasubramaniaan msivasubramaniaan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmilosz @ksathyanm @gorkem