Auto-implement ConnectionLike for DerefMut #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides an implementation of `ConnectionLike` for any type that can be mutably and immutably dereferenced to an implementation of `ConnectionLike` through `DerefMut`. The primary motivation is being able to use `r2d2::PoolConnection`s directly to satisfy `ConnectionLike`, which makes code using pooled connections easier to read. A blanket impl for `r2d2::PoolConnection` would suffice but this is more generalised as not to be r2d2 specific.
holmesmr
force-pushed
the
holmesmr/impl-deref-connlike
branch
from
3f2b63b
to
cdd10ec
Compare
holmesmr
changed the title
|
Apologies - revised this PR as I remembered immediately after opening that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an implementation of
ConnectionLikefor any type that can be mutably and immutably dereferenced to an implementation ofConnectionLikethroughDerefMut. The primary motivation is being able to user2d2::PoolConnections directly to satisfyConnectionLike, which makes code using pooled connections easierto read. A blanket impl for
r2d2::PoolConnectionwould suffice for this case, but this is more generalised as not to be r2d2 specific, which would also make it usable for other storage types providingDerefMut.