Feat: GETEX and GETDEL Added #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @djc ! Can you please approve this? |
djc
reviewed
May 30, 2022
src/commands.rs
Outdated
| @@ -397,6 +397,16 @@ implement_commands! { | |||
| cmd("PTTL").arg(key) | |||
| } | |||
|
|
|||
| /// Get the value of a key and set expiration | |||
| fn get_ex<K: ToRedisArgs>(key: K, seconds: usize) { | |||
There was a problem hiding this comment.
For get_ex, I think it would be good to support EX/PX/EXAT/PXAT and PERSIST options as well. For the former, it probably makes sense to define an enum, or maybe a custom Duration type with some simple constructors?
There was a problem hiding this comment.
I have now added support for those options and also created tests for get_ex and get_del. CI shows that build failed on 1.51.0 but I think that is due to unrelated issue. Can you please review the changes?
djc
reviewed
Jun 2, 2022
|
I have made the requested changes. |
|
Thanks! |
nonirosenfeldredis
pushed a commit
to nonirosenfeldredis/redis-rs
that referenced
this pull request
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following commands:
Closes #485