Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add username to ClusterClient and ClusterConnection #596

Merged
merged 1 commit into from May 14, 2022
Merged

Add username to ClusterClient and ClusterConnection #596

merged 1 commit into from May 14, 2022

Conversation

gildaf
Copy link
Contributor

@gildaf gildaf commented Apr 13, 2022

This is a fix to issue #595

doyshinda
doyshinda approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@doyshinda doyshinda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gkorland
Copy link
Contributor

gkorland commented May 8, 2022 •
edited

@Marwes @mitsuhiko can you please merge this PR?

@jaymell jaymell merged commit 13eeb2c into redis-rs:master May 14, 2022
@jaymell jaymell mentioned this pull request May 14, 2022
Closed
@djc djc mentioned this pull request May 16, 2022
Closed
gkorland pushed a commit to gkorland/redis-rs that referenced this pull request May 24, 2022
@gildaf @gkorland
Add username to ClusterClient and ClusterConnection (redis-rs#596)
9075478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doyshinda doyshinda doyshinda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gildaf @gkorland @doyshinda @jaymell