Miscellaneous Cargo improvements #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This usually doesn't make sense for libraries.
tasn
reviewed
May 25, 2022
| @@ -1,7 +1,6 @@ | |||
| [package] | |||
| name = "redis" | |||
| version = "0.21.5" | |||
| authors = ["Armin Ronacher <armin.ronacher@active-4.com>", "Jan-Erik Rediger <janerik@fnordig.de>"] | |||
There was a problem hiding this comment.
Maybe put:
authors = "Redis-rs Authors"I think they is useful for both copyright purposes and general metadata. I'm sure there are things that expect this.
There was a problem hiding this comment.
I'm not convinced -- I've removed this field from most of the crates that I help maintain and it's been fine. I don't see any value in terms of general metadata from such a generic description.
There was a problem hiding this comment.
OK, I'm surprised that cargo publish doesn't complain about it. All good then. :)
jaymell
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.