Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using ahash internally & for redis values #636

Merged
merged 1 commit into from Jun 20, 2022

Conversation

utkarshgupta137
Copy link
Contributor

No description provided.

@utkarshgupta137 utkarshgupta137 changed the title add support for using ahash internally & for redis values Add support for using ahash internally & for redis values Jun 17, 2022
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jaymell jaymell merged commit 624a59a into redis-rs:main Jun 20, 2022
@utkarshgupta137 utkarshgupta137 deleted the ahash branch June 20, 2022 16:40
@jqnatividad
Copy link

Hi folks,
How do you use the "ahash" feature as its not listed as a feature in the Cargo.toml file?

@djc
Copy link
Contributor

djc commented Jul 3, 2022

Optional dependencies implicitly create a feature toggle.

@utkarshgupta137
Copy link
Contributor Author

@djc I think we need a new release for people to be able to use it.

@djc
Copy link
Contributor

djc commented Jul 4, 2022

Well, you can use it now as a Git dependency, and that seems to be orthogonal.

@jqnatividad
Copy link

@djc, It seems that if you use an optional dependency that is not explicitly declared a feature, you're prevented from publishing it on crates.io:

$ cargo publish --dry-run --allow-dirty
    Updating crates.io index
   Packaging qsv v0.58.2 (/Users/johndoe/Documents/GitHub/qsv)
error: failed to prepare local package for uploading

Caused by:
  failed to select a version for `redis`.
      ... required by package `qsv v0.58.2 (/Users/johndoe/Documents/GitHub/qsv)`
  versions that meet the requirements `^0.21` are: 0.21.5, 0.21.4, 0.21.3, 0.21.2, 0.21.1, 0.21.0

  the package `qsv` depends on `redis`, with features: `ahash` but `redis` does not have these features.

@utkarshgupta137
Copy link
Contributor Author

Should I raise a PR to create a feature for this then?

@djc
Copy link
Contributor

djc commented Jul 8, 2022

@djc, It seems that if you use an optional dependency that is not explicitly declared a feature, you're prevented from publishing it on crates.io:

I think this is wrong. If you want to publish qsv to crates.io it's not allowed to have git dependencies but this PR has not yet been released to crates.io. So what you're seeing here just means that the released versions don't have a feature called ahash which is clearly expected. See #594 to track release planning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants