make docs and make lint warning fixes
#642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a variety of warnings that come up when running `cargo clippy --all-features --all --tests --examples -- -D clippy::all -D warnings` and `make docs` on rustc 1.61.0.
djc
approved these changes
Jun 26, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #641, I ran into warnings executing
make docsandmake lintthat weren't related to my PR; thought I would make another PR so that others wouldn't run into this when running these commands.It seems like CI passes in spite of these warnings. I'm not an expert at GitHub workflows and didn't see anything wrong with how things are set up. Maybe something's wrong on my side? Currently running
rustc 1.61.0 (fe5b13d68 2022-05-18).