Add support to casting RedisResult to CString. #660
Merged
+56
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The linter seems to fail on code that isn't a part of this PR. |
|
#663 cleans up the unrelated clippy failures. |
|
This seems reasonable to me. @jaymell what do you think? |
djc
reviewed
Aug 16, 2022
nihohit
force-pushed
the
cstring-support
branch
2 times, most recently
from
13ad495
to
36a641a
Compare
|
Looks good. Should we add a couple simple tests? |
|
@jaymell I'll be happy to add some, but I don't see equivalent |
Nothing special, there are some similar examples if you look at the other type tests, e.g., make sure that a null byte in a value returns the error we expect. |
nihohit
force-pushed
the
cstring-support
branch
2 times, most recently
from
043435e
to
16794e3
Compare
nihohit
force-pushed
the
cstring-support
branch
from
0572b16
to
8b3a940
Compare
|
@jaymell added tests. |
djc
approved these changes
Aug 18, 2022
|
Thanks! |
shachlanAmazon
added a commit
to shachlanAmazon/glide-for-redis
that referenced
this pull request
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.