New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add derive Clone and as_map method to InfoDict #661
Conversation
This would also help to fix #631 |
I'm fine with the (Clippy failures can be ignored, see #663.) |
@djc first of all, it is possible, and I can do it to move with this PR (Should we implement a new
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think we should probably implement Deref<Target = &HashMap<String, Value>>
instead of adding as_map()
. That would also allow us to get rid of some of the simple proxy methods.
adedf5b
to
960d878
Compare
@djc removed as_map in favour of Deref |
Thanks! @jaymell want to take a look? |
Looks good! |
No description provided.