Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

impl Debug for MultiplexedConnection & Pipeline #664

Merged
merged 1 commit into from Aug 22, 2022
Merged

impl Debug for MultiplexedConnection & Pipeline #664

merged 1 commit into from Aug 22, 2022

Conversation

elpiel
Copy link
Contributor

@elpiel elpiel commented Aug 20, 2022 •
edited

Resolves #649
This allows the usage of #[instrument] when using the tracing crate.
All generics of Pipeline used in MultiplexedConnection impl Debug this is why I've added an impl of Pipeline only when all of them also impl Debug:

pub struct MultiplexedConnection {
    pipeline: Pipeline<Vec<u8>, Value, RedisError>,
    db: i64,
}

cc @djc

@elpiel elpiel force-pushed the debug-impls-for-multiplexed-connection branch from 2d0fdaa to f576da6 Compare August 20, 2022 23:30
@djc djc merged commit c5b5cd1 into redis-rs:main Aug 22, 2022
@djc
Copy link
Contributor

djc commented Aug 22, 2022

Thanks!

@elpiel
Copy link
Contributor Author

elpiel commented Aug 22, 2022

Whoop whoop, Thank you as well!

@elpiel elpiel deleted the debug-impls-for-multiplexed-connection branch August 22, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug impl for MultiplexedConnection & Pipeline
2 participants
@elpiel @djc