Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1/5] cluster: implement proper builder pattern & minor refactor #669

Merged
merged 4 commits into from Aug 31, 2022
Merged

[1/5] cluster: implement proper builder pattern & minor refactor #669

merged 4 commits into from Aug 31, 2022

Commits on Jul 24, 2022

  1. cluster_client: use ClusterParams struct to pass params 

    - this is to simplify passing multiple params to & inside ClusterConnection impl
    @utkarshgupta137
    utkarshgupta137 committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    7bbac5f View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. cluster_client: add handling for empty initial_nodes

    @utkarshgupta137
    utkarshgupta137 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    f3fd7d2 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. cluster_client: move code 

    - move build method to builder
- move open methods to the bottom
    @utkarshgupta137
    utkarshgupta137 committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    28b1780 View commit details
    Browse the repository at this point in the history

  2. cluster_client: implement proper builder pattern 

    - implement proper builder pattern by adding `new` & `builder` methods to ClusterClient and `new` & `build` methods to ClusterClientBuilder
- deprecate & redirect `open` methods for ClusterClient & ClusterClientBuilder
    @utkarshgupta137
    utkarshgupta137 committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    53e6c4b View commit details
    Browse the repository at this point in the history