Add Rule::Other to cover newly defined flags. #682

[garyhai]

Fix bug of unhandled newly defined flags when call acl_getuser.

[djc]

Thanks for helping out!

This technically still breaks compatibility, since it adds a variant on an enum that is not marked as non-exhaustive. That's fine, though, since the main branch already broke compatibility. Given that this is the case, I think it would make sense to also add variants for any newly defined flags that we know about at this point.

[garyhai]

This technically still breaks compatibility, since it adds a variant on an enum that is not marked as non-exhaustive. That's fine, though, since the main branch already broke compatibility. Given that this is the case, I think it would make sense to also add variants for any newly defined flags that we know about at this point.

Instead of causing compatibility issues every time a new flag is added, Rule::Other is used as a transitional solution to ease compatibility. Rule may enumerate explicitly a list of commonly used flags.

[djc]

This looks good to me. @jaymell any thoughts?

[jaymell]

I can be persuaded here, but I'm not thrilled with the change. The core issue, of course, is the existing API has not left us with great options. But I wonder if, given that we're going to make a backward-incompatible change here, if we should consider marking the enum as non-exhaustive and adding in the new variants as appropriate?

[garyhai]

I can be persuaded here, but I'm not thrilled with the change. The core issue, of course, is the existing API has not left us with great options. But I wonder if, given that we're going to make a backward-incompatible change here, if we should consider marking the enum as non-exhaustive and adding in the new variants as appropriate?

The non-exhaustion structure has too many limitations and imposes too much mental burden. Rule::Other is just for exhaustion and ergonomics. I suggest putting this break change into the next non-compatibility release.

[jaymell]

Ok, merging this. Thanks for the contribution.