[2/5] [3] cluster: move connect to main impl

[0xWOF]

Changes

• cluster: move connect function to ClusterConnection impl
• cluster: follow up usage code of connect function

Effect

• cluster:
  • no public api is changed
  • code is changed but behavior will not be changed

Note

• this PR is from cluster: simplify TlsMode logic, add param to builder, & refactor create_initial_connections/connect #690
• this PR is depends on [2/5] [2] cluster, cluster_client: minor refactorings (change order of code, use Self) #706
• you can check actual file changes on [2/5] [3] cluster: move connect to main impl 0xWOF/redis-rs#15

[djc]

This mostly looks good to me.

[djc]

Please rebase. I recommend changing your PRs so each PR targets the previous one's branch instead of main. GitHub will update as the original PR gets merged, and the commit view in this PR is actually useful.

[0xWOF]

I didn't know that. Thank you for notify to me. I'll rebase it as soon as possible. And I'll apply this rule to other PRs.

[0xWOF]

@djc I finish rebase. But I can't satisfy this recommend because I have no permission to create branch on redis-rs/redis-rs repository. And PR of 0xWOF:cluster_client_refactor_2_4 to 0xWOF:cluster_client_refactor_2_3 is not PR of redis-rs/redis-rs repository is PR of 0xWOF/redis-rs repository.

I recommend changing your PRs so each PR targets the previous one's branch instead of main.

Instead, I'll create PR one by one after PR 5. If you know other better way, please share to me.
Thanks!

[djc]

Creating them one by one seems reasonable to me, and is actually easier on my GitHub notifications.