Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2/5] [5] cluster: make create_initial_connections as method, call refresh_slots in create_initial_connections #716

Merged
merged 2 commits into from
Nov 10, 2022
Merged

[2/5] [5] cluster: make create_initial_connections as method, call refresh_slots in create_initial_connections #716

merged 2 commits into from
Nov 10, 2022

Conversation

0xWOF
Copy link
Contributor

@0xWOF 0xWOF commented Nov 9, 2022

Changes

  • cluster
    • make create_initial_connections as method
    • call refresh_slots in create_initial_connections

Effect

  • cluster:
    • no public api is changed
    • no behavior is changed
    • usage of create_initial_connections is changed

Note

utkarshgupta137 and others added 2 commits November 9, 2022 22:59
@utkarshgupta137 @0xWOF
cluster: make create_initial_connections a method
8d039ef 
- set connections in create_initial_connections instead of returning
- access username, password, read_from_replicas from self to reduce repetitive parameter passing

cluster: use modified create_initial_connections
@0xWOF
cluster: call refresh_slots in create_initial_connections instead of …
70f5151 
…calling each time
@djc djc merged commit 9c53a5f into redis-rs:main Nov 10, 2022
@0xWOF 0xWOF deleted the cluster_client_refactor_2_5 branch November 10, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0xWOF @djc @utkarshgupta137