Improve error logging. #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds the error's kind to the string representation of the error. So the error that was `An error was signalled by the server: 10279 127.0.0.1:39192` will now be `An error was signalled by the server - Moved: 10279 127.0.0.1:39192` which makes the error much clearer.
|
Good call -- thanks! |
jaymell
approved these changes
May 9, 2023
shachlanAmazon
added a commit
to shachlanAmazon/glide-for-redis
that referenced
this pull request
May 9, 2023
The fix was merged to redis-rs: redis-rs/redis-rs#838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the error's kind to the string representation of the error. So the error that was
An error was signalled by the server: 10279 127.0.0.1:39192will now be
An error was signalled by the server - Moved: 10279 127.0.0.1:39192which makes the error much clearer.