Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newtype SlotMap #845

Merged
merged 1 commit into from
May 23, 2023
Merged

Newtype SlotMap #845

merged 1 commit into from
May 23, 2023

Conversation

jaymell
Copy link
Contributor

@jaymell jaymell commented May 22, 2023

Make SlotMap a struct for better abstraction
and code de-duplication

nihohit
nihohit approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@nihohit nihohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

redis/src/cluster_routing.rs Outdated Show resolved Hide resolved
@jaymell
Newtype SlotMap
428d3f9 
Make `SlotMap` a struct for better abstraction
and code de-duplication
@jaymell jaymell merged commit 33b6fed into redis-rs:main May 23, 2023
9 checks passed
@jaymell jaymell deleted the newtype-slotmap branch May 23, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nihohit nihohit nihohit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaymell @nihohit