Allow configuration of cluster retry wait duration #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymell
approved these changes
Jun 27, 2023
This change allows the user to configure the wait duration between retry attempts in the cluster clients. This change also introduces jitter, so that if multiple requests are waiting, they won't be all sent at exactly the same time.
During the development of the feature I ran tests with lower wait time between retries, and often received CLUSTERDOWN errors. This means that RedisCluster wasn't ready to use when constructed.
nihohit
force-pushed
the
configure-retries
branch
from
e04725c
to
7b81899
Compare
|
@jaymell rebased |
altanozlu
pushed a commit
to altanozlu/redis-rs
that referenced
this pull request
Aug 16, 2023
* Allow configuration of cluster retry wait duration This change allows the user to configure the wait duration between retry attempts in the cluster clients. This change also introduces jitter, so that if multiple requests are waiting, they won't be all sent at exactly the same time. * Test cluster: wait for status ok in log file. During the development of the feature I ran tests with lower wait time between retries, and often received CLUSTERDOWN errors. This means that RedisCluster wasn't ready to use when constructed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the user to configure the wait duration between retry
attempts in the cluster clients. The change doesn't the current wait time,
but it does contain a fix to the tests, which will allow us to reduce the defaults
without breaking the tests.
This change also introduces jitter, so that if multiple requests
are waiting, they won't be all sent at exactly the same time.