Fix minor async client bug. #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`connections.remove(addr),` in the old code always returned `None`, because `connections` in the fold operation was an empty map. This change ensures that connections from the external `connections` variable will be used in the fold operation.
jaymell
approved these changes
Jun 12, 2023
|
Thanks for fixing this! |
altanozlu
pushed a commit
to altanozlu/redis-rs
that referenced
this pull request
Aug 16, 2023
`connections.remove(addr),` in the old code always returned `None`, because `connections` in the fold operation was an empty map. This change ensures that connections from the external `connections` variable will be used in the fold operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connections.remove(addr),in the old code always returnedNone, becauseconnectionsin the fold operation was an empty map. This change ensures that connections from the externalconnectionsvariable will be used in the fold operation.lenwas removed from SlotMap because it's no longer in use.