Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix async connect when ns resolved to multi ip #872

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Fix async connect when ns resolved to multi ip #872

merged 5 commits into from
Jun 27, 2023

Conversation

hugefiver
Copy link
Contributor

fix #871

nihohit
nihohit approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@nihohit nihohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments. Looking good!

redis/src/aio/connection.rs Outdated Show resolved Hide resolved
redis/src/aio/connection.rs Show resolved Hide resolved
redis/src/aio/connection.rs Outdated Show resolved Hide resolved
@hugefiver hugefiver requested a review from nihohit June 21, 2023 13:44
nihohit
nihohit approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@nihohit nihohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jaymell

redis/src/aio/connection.rs Show resolved Hide resolved
@hugefiver hugefiver requested a review from nihohit June 22, 2023 10:12
@nihohit
Copy link
Contributor

nihohit commented Jun 25, 2023

@hugefiver do you think this is possible to test in CI, or does it require a specific machine config?

@hugefiver
Copy link
Contributor Author

hugefiver commented Jun 25, 2023 •
edited

Maybe it's possible to simulate it by modifying hosts file, such as binding the l1 domain to 127.0.0.{1,2,3}, etc. The example in the issue is in this way. maybe running a DNS server also works, or directly mock the function of querying DNS in tokio library (not sure if it's possible)

I have no idea which one to choose.

@nihohit
Copy link
Contributor

nihohit commented Jun 25, 2023

yeah, all of the above sound over the top. nevermind.

@jaymell jaymell merged commit 84efb23 into redis-rs:main Jun 27, 2023
9 checks passed
@jaymell
Copy link
Contributor

jaymell commented Jun 27, 2023

Thanks for this!

altanozlu pushed a commit to altanozlu/redis-rs that referenced this pull request Aug 16, 2023
@hugefiver @altanozlu
Fix async connect when ns resolved to multi ip (redis-rs#872)
6e8763e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymell jaymell jaymell approved these changes

@nihohit nihohit Awaiting requested review from nihohit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Different behavior of sync and async get connection methods
3 participants
@hugefiver @nihohit @jaymell