Remove connection checking on every request. #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently every request is prepended with a PING, and is only sent when the ping completes. This slows down performance significantly - removing this increased TPS on my test machine by 50%.
jaymell
approved these changes
Jun 22, 2023
|
Thanks for catching this! |
altanozlu
pushed a commit
to altanozlu/redis-rs
that referenced
this pull request
Aug 16, 2023
Currently every request is prepended with a PING, and is only sent when the ping completes. This slows down performance significantly - removing this increased TPS on my test machine by 50%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently every request is prepended with a PING, and is only sent when the ping completes. This slows down performance significantly - removing this increased TPS on my test machine by 50%.