Improve async cluster client performance. #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing connections, which were received on the happy path, were wrapped 4 times - 2 boxes, 2 shares. Maybe more, if the compiler had to move the connection to heap for the boxed/shared generator. This change removes all of these unnecessary allocations.
Now all the calls pass `true`, so the argument is no longer needed.
|
I also checked, and |
jaymell
approved these changes
Jun 27, 2023
|
This looks good -- thanks for cleaning this up! |
altanozlu
pushed a commit
to altanozlu/redis-rs
that referenced
this pull request
Aug 16, 2023
* Remove unnecessary .boxed().shared() calls. Existing connections, which were received on the happy path, were wrapped 4 times - 2 boxes, 2 shares. Maybe more, if the compiler had to move the connection to heap for the boxed/shared generator. This change removes all of these unnecessary allocations. * Remove argument from get_or_create_conn. Now all the calls pass `true`, so the argument is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reverts most of the performance degradation introduced recently. Using this benchmark I measured ~320K TPS on version 0.23, ~160K TPS on main, and ~295K TPS after this change.
The cause of the degradation seems to be that existing connections, which were received on the happy path, were wrapped 4 times - 2 boxes, 2 shares. Maybe more, if the compiler had to move the connection to heap for the boxed/shared generator. This change removes all of these unnecessary allocations.