Benchmark CI #880
Merged
Benchmark CI #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are the criteria for this to fail? How much difference is not acceptable? |
|
Still testing... stay tuned |
jaymell
force-pushed
the
benchmark-ci
branch
3 times, most recently
from
9dd8d05
to
7a29986
Compare
|
Well, I am sufficiently demoralized by benchmarking thus far that I'm almost reluctant to merge this, but it's possibly better than not running benchmarks at all, so it may be worth letting it run on PRs for awhile to see how things look over time. I think it's probably a futile/unwise endeavor to try and assess pass/failure running in CI, and none of the tooling here is really designed for that anyway, so likely better for now to just have the results available to look at. |
jaymell
force-pushed
the
benchmark-ci
branch
3 times, most recently
from
af4bfc2
to
7116555
Compare
nihohit
pushed a commit
to amazon-contributing/redis-rs
that referenced
this pull request
Jul 23, 2023
Add basic benchmark reporting to CI
altanozlu
pushed a commit
to altanozlu/redis-rs
that referenced
this pull request
Aug 16, 2023
Add basic benchmark reporting to CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.