Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routing data for commands. #887

Merged
merged 2 commits into from
Jul 23, 2023
Merged

Conversation

nihohit
Copy link
Contributor

@nihohit nihohit commented Jul 13, 2023

The choices were based on the request_policy tip from the COMMAND output.

The choices were based on the request_policy tip from the COMMAND
output.
@nihohit
Copy link
Contributor Author

nihohit commented Jul 13, 2023

tasks for after this PR:
implement multi-shard commands
implement response policies

@jaymell
Copy link
Contributor

jaymell commented Jul 21, 2023

I think this looks good! Can you list out which commands you've removed from the routing rules? I think they are all appropriate for random routing?

@nihohit
Copy link
Contributor Author

nihohit commented Jul 21, 2023

readonly commands:
added:
LOLWUT
MEMORY USAGE
OBJECT ENCODING
OBJECT FREQ
OBJECT IDLETIME
OBJECT REFCOUNT
XINFO CONSUMERS
XINFO GROUPS
XINFO STREAM

(the OBEJCT & XINFO commands were expanded from only OBJECT & XINFO in the old version)
removed:
CLIENT
ECHO
LASTSAVE
STRALGO

AllNodes routing -
all removed, except for SLOWLOG & CONFIG SET
DBSIZE, PING, INFO, KEYS were moved to AllMasters list.
BGREWRITEAOF, CLIENT LIST, ECHO, other CONFIG commands, other CLIENT commands, LASTSAVE, don't have explicit routing now.

AllMasters:
SCRIPT FLUSH, SCRIPT LOAD, have been moved to AllNodes. SCRIPT DEBUG, SCRIPT HELP now don't have explicit routing.

@jaymell jaymell merged commit 9083a74 into redis-rs:main Jul 23, 2023
9 checks passed
@nihohit nihohit deleted the routing branch July 23, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants