Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AsyncConnection usage in sentinel if aio feature is not used. #923

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

brocaar
Copy link
Contributor

@brocaar brocaar commented Aug 8, 2023

Hello @jaymell I believe this should fix the issue with the aio import within sentinel (#922).

@nihohit
Copy link
Contributor

nihohit commented Aug 8, 2023

@brocaar how can the issue be replicated? I tried running cargo build --features sentinel and it completed succesfully.

@felipou
Copy link
Contributor

felipou commented Aug 8, 2023

I replicated it by using the redis crate in another crate, using only the sentinel feature. I don't know why the build command is not failing though.

@nihohit
Copy link
Contributor

nihohit commented Aug 8, 2023

Well, it's a real shame if we can't add to the CI some way of checking whether dependencies are broken in this way.
@jaymell, any ideas?

@jaymell
Copy link
Contributor

jaymell commented Aug 9, 2023

@nihohit I've seen errors like this get masked previously by the redis-test crate. If you explicitly build only the redis crate, you will see the issue, i.e. with cargo build -p redis --features sentinel.

It looks like there is a tool tokio is using called cargo-hack that can test features individually, which we can probably wire up easily in CI to do a check per dependency. Let me see if I can throw something together.

@jaymell
Copy link
Contributor

jaymell commented Aug 9, 2023

Thanks for the quick turnaround on the PR. @brocaar if you rebase your PR, the checks should all pass.

@brocaar
Copy link
Contributor Author

brocaar commented Aug 9, 2023

Thanks for the review. @jaymell I have just pushed my rebased changes.

@nihohit nihohit merged commit e5727a1 into redis-rs:main Aug 9, 2023
10 checks passed
altanozlu pushed a commit to altanozlu/redis-rs that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants