RediSearch Support #2801
Open
RediSearch Support #2801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayim
reviewed
Nov 20, 2023
chayim
reviewed
Nov 20, 2023
chayim
reviewed
Nov 20, 2023
chayim
reviewed
Nov 20, 2023
chayim
reviewed
Nov 20, 2023
chayim
reviewed
Nov 20, 2023
chayim
reviewed
Nov 20, 2023
chayim
reviewed
Nov 20, 2023
chayim
reviewed
Nov 20, 2023
chayim
reviewed
Nov 20, 2023
chayim
reviewed
Nov 20, 2023
| var client *redis.Client | ||
|
|
||
| BeforeEach(func() { | ||
| client = redis.NewClient(&redis.Options{Addr: ":6379"}) |
There was a problem hiding this comment.
Can you get the Addr from the same client we already use?
chayim
reviewed
Nov 20, 2023
| Expect(err).NotTo(HaveOccurred()) | ||
| searchResult := res.(map[interface{}]interface{}) | ||
| Expect(searchResult["total_results"]).To(BeEquivalentTo(int64(2))) | ||
| Expect(searchResult["results"].([]interface{})[0].(map[interface{}]interface{})["id"]).To(BeEquivalentTo("doc2")) |
There was a problem hiding this comment.
This looks uncastable. can you try?
There was a problem hiding this comment.
IMHO points to the need for helpers on the return
There was a problem hiding this comment.
Handling unstable return types like in the FTSearch function is challenging due to Go's static typing. Creating a helper function to determine the return type isn’t feasible due to the dynamic nature of the return type and the infinite possible variations.
stivesso
added a commit
to stivesso/articles-search
that referenced
this pull request
Feb 12, 2024
Ref: https://github.com/redis/go-redis/blob/e3d522fef42f0e0dea0ac228cefaac65df2f0e41/search_test.go redis/go-redis#2801 Signed-off-by: Steve ESSO <stivesso@gmail.com>
|
how is this mr going？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.