add server address and port span attributes to redis otel trace instrumentation #2826
+101
−555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmihailenco
reviewed
Jan 25, 2024
esara
force-pushed
the
netpeer
branch
3 times, most recently
from
87977c3
to
07d2151
Compare
esara
changed the title
esara
changed the title
esara
force-pushed
the
netpeer
branch
2 times, most recently
from
9ec3724
to
bbebed0
Compare
esara
force-pushed
the
netpeer
branch
2 times, most recently
from
f3aacad
to
c4eaa5d
Compare
vmihailenco
reviewed
Mar 24, 2024
|
@esara LGTM, but I think we should keep |
vmihailenco
reviewed
Mar 25, 2024
vmihailenco
previously approved these changes
Mar 25, 2024
vmihailenco
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address #2825