Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow for pubsub connections to optionally be taken from pool #2869

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vtermanis
Copy link

@vtermanis
Copy link
Author

Only the RE Tests suite fails - it's not able to find an (internal?) docker image. I believe there's nothing I can do about that.

- After use, they are removed from the pool
- Only applicable to non-cluster client
@vtermanis
Copy link
Author

vtermanis commented Feb 15, 2024

@ofekshenawa thank you for taking a look. Are you sure it's a breaking change? The way I've tried to write should mean that both from a behaviour and performance perspective it behaves as before unless the new configuration flag is explicitly set.
(Unless you mean the fact that for now it's only for the non cluster client. I didn't update those so I could age what you, the developers/maintainers, think.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants