Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test case for CLIENT KILL with MAXAGE option #2971

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added test case for CLIENT KILL with MAXAGE option #2971

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8879e3a
Added test case for CLIENT KILL with MAXAGE option
vladvildanov Apr 15, 2024
9d683aa
Fixed sleep value
vladvildanov Apr 15, 2024
6659cf0
Added additional condition to kill specific connection
vladvildanov Apr 16, 2024
2c71300
Test commit
vladvildanov Apr 16, 2024
4397053
Test commit
vladvildanov Apr 16, 2024
7784beb
Updated test case to handle timeouts
vladvildanov Apr 16, 2024
0b8a94a
Merge branch 'master' of github.com:redis/go-redis into vv-client-kil…
vladvildanov May 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
34 changes: 34 additions & 0 deletions commands_test.go
View file
Open in desktop
Expand Up @@ -193,6 +193,40 @@ var _ = Describe("Commands", func() {
Expect(r.Val()).To(Equal(int64(0)))
})

It("should ClientKillByFilter with MAXAGE", func() {
var s []string
started := make(chan bool)
done := make(chan bool)

go func() {
defer GinkgoRecover()

started <- true
blpop := client.BLPop(ctx, 0, "list")
Expect(blpop.Val()).To(Equal(s))
done <- true
}()
<-started

select {
case <-done:
Fail("BLPOP is not blocked.")
case <-time.After(2 * time.Second):
// ok
}

killed := client.ClientKillByFilter(ctx, "MAXAGE", "1")
Expect(killed.Err()).NotTo(HaveOccurred())
Expect(killed.Val()).To(Equal(int64(2)))

select {
case <-done:
// ok
case <-time.After(time.Second):
Fail("BLPOP is still blocked.")
}
})

It("should ClientID", func() {
err := client.ClientID(ctx).Err()
Expect(err).NotTo(HaveOccurred())
Expand Down