chore: Pass keepAlive and noDelay options during createConnection

redis · Mar 30, 2022 · f39acf4 · f39acf4
1 parent d63e70b
commit f39acf4
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/lib/Redis.ts b/lib/Redis.ts
@@ -262,10 +262,6 @@ class Redis extends Commander {
             stream.once("close", eventHandler.closeHandler(_this));
           }
 
-          if (options.noDelay) {
-            stream.setNoDelay(true);
-          }
-
           const connectionReadyHandler = function () {
             _this.removeListener("close", connectionCloseHandler);
             resolve();

diff --git a/lib/connectors/StandaloneConnector.ts b/lib/connectors/StandaloneConnector.ts
@@ -8,6 +8,8 @@ export type StandaloneConnectionOptions = (Partial<TcpNetConnectOpts> &
   Partial<IpcNetConnectOpts>) & {
   disconnectTimeout?: number;
   tls?: ConnectionOptions;
+  noDelay?: boolean;
+  keepAlive?: number;
 };
 
 export default class StandaloneConnector extends AbstractConnector {
@@ -41,6 +43,16 @@ export default class StandaloneConnector extends AbstractConnector {
       Object.assign(connectionOptions, options.tls);
     }
 
+    if (options.noDelay === true) {
+      connectionOptions.noDelay = true;
+    }
+
+    if (typeof options.keepAlive === 'number') {
+      connectionOptions.keepAlive = true;
+      connectionOptions.keepAliveInitialDelay = options.keepAlive;
+    }
+
+
     // TODO:
     // We use native Promise here since other Promise
     // implementation may use different schedulers that

diff --git a/lib/redis/event_handler.ts b/lib/redis/event_handler.ts
@@ -16,10 +16,6 @@ export function connectHandler(self) {
 
     self.resetCommandQueue();
 
-    if (typeof self.options.keepAlive === "number") {
-      self.stream.setKeepAlive(true, self.options.keepAlive);
-    }
-
     // AUTH command should be processed before any other commands
     let flushed = false;
     const { connectionEpoch } = self;