fix: clear script caches interval on each connection attempt

[ejose19]

Follow-up fix for: #1215

After using tools like why-is-node-running, I saw:

this._addedScriptHashesCleanInterval = setInterval(() => {
  this._addedScriptHashes = {};
}, this.options.maxScriptsCachingTime);

appearing multiple times (after quit was called), which means quit was only clearing the last of them, but there were many that were overwritten by that same call when connect is called multiple times (as in not connecting the first time). This PR ensures that the interval is cleared before assigning a new one to the variable holding them.

[AVVS]

Hey, this looks awesome. Any chance you are able to add a test case for this so that we can ensure there are no regressions in the future?

[ejose19]

I couldn't think of any test for this particular fix, as the way I found it is either using a low level tool why-is-node-running, or noticing why the server was hanging on SIGTERM, but the tests are ignoring background intervals so I don't know how I would be able to test them (ioredis still closes without issues, but the node process does not end). If you know of any test case for it using the existing test tools I may be able to work on it.

[ShogunPanda]

@ejose19 Thanks for filing this.

After your bug report, I've investigated separately and I found the same fix, which I incorporated in #1226.

@AVVS I've tried to add a test case in that PR as well, but honestly I was not able to reproduce the failure as well.

[ioredis-robot]

🎉 This issue has been resolved in version 4.19.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀