Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor compatibility issues caused by TypeScript upgrade #1309

Merged
merged 1 commit into from
Mar 24, 2021
Merged

Conversation

luin
Copy link
Collaborator

@luin luin commented Mar 24, 2021

Closes #1308

TypeScript 3.9 changes the export signatures that cause some compatibility issues. This PR downgrade it to 3.8.3 to solve the issue. We'll consider TypeScript upgrade as a breaking change so will include it in the next major version.

@luin luin merged commit c96139a into master Mar 24, 2021
@luin luin deleted the zh-ts-1308 branch March 24, 2021 05:25
ioredis-robot pushed a commit that referenced this pull request Mar 24, 2021
## [4.24.4](v4.24.3...v4.24.4) (2021-03-24)

### Bug Fixes

* minor compatibility issues caused by TypeScript upgrade ([#1309](#1309)) ([c96139a](c96139a)), closes [#1308](#1308)
@ioredis-robot
Copy link
Collaborator

🎉 This PR is included in version 4.24.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

janus-dev87 added a commit to janus-dev87/ioredis-work that referenced this pull request Mar 1, 2024
## [4.24.4](redis/ioredis@v4.24.3...v4.24.4) (2021-03-24)

### Bug Fixes

* minor compatibility issues caused by TypeScript upgrade ([#1309](redis/ioredis#1309)) ([c96139a](redis/ioredis@c96139a)), closes [#1308](redis/ioredis#1308)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis.Cluster can't mocked by Jest
2 participants