Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support CLIENT KILL [MAXAGE] #2782

Merged
merged 5 commits into from May 14, 2024

Conversation

dengliming
Copy link
Collaborator

@dengliming dengliming commented Mar 12, 2024

closes #2765

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@mp911de mp911de added the type: enhancement A general enhancement label Mar 13, 2024
@tishun
Copy link
Collaborator

tishun commented Apr 16, 2024

@mp911de should we merge this one?

@mp911de
Copy link
Collaborator

mp911de commented Apr 16, 2024

I have a few changes to propose:

  • Set @since tags to 7.0
  • Improve the test arrangement as a Redis node can have multiple inactive clients. We should be able to clearly identify the clients to disconnect

Other than that, it's fine to merge this PR.

@tishun
Copy link
Collaborator

tishun commented May 2, 2024

@dengliming would you be able to address the changes @mp911de suggested?

Copy link
Collaborator

@uglide uglide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uglide uglide merged commit cc9d240 into redis:main May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command filter for CLIENT KILL to support maximum age via [MAXAGE] option
4 participants