#2285-Add-example-scripts-hyperloglog - Added hyperloglog examples to… #2289
Conversation
…es to address Issue redis#2285
|
Closes #2285 when merged. |
examples/hyperloglog.js
Outdated
| @@ -0,0 +1,51 @@ | |||
| //Example to log traffic data at intersections for the city of San Francisco. | |||
There was a problem hiding this comment.
Please put a space after // in comments throughout, thanks.
There was a problem hiding this comment.
Thank you - looking good, the code works well thanks. I've left a couple of suggestions, please ensure all comments have a space between the // and the text, and that sentences end with a full stop / period... so:
// this is a comment.
rather than:
//this is a comment
Thank you!
examples/hyperloglog.js
Outdated
| @@ -0,0 +1,51 @@ | |||
| //Example to log traffic data at intersections for the city of San Francisco. | |||
| //Log license plates of each car scanned at each intersection and add to the intersections Hyperloglog | |||
There was a problem hiding this comment.
| //Log license plates of each car scanned at each intersection and add to the intersections Hyperloglog | |
| // Log license plates of each car scanned at each intersection and add to the intersections Hyperloglog. |
examples/hyperloglog.js
Outdated
|
|
||
| await client.connect(); | ||
|
|
||
| //To Create a HyperLogLog, the `pfAdd` method is used. |
There was a problem hiding this comment.
| //To Create a HyperLogLog, the `pfAdd` method is used. | |
| // Use `pfAdd` to add an element to a Hyperloglog, creating the Hyperloglog if necessary. |
|
@simonprickett Thanks for the feedback, Changes made |
ade1705
requested review from
simonprickett
and removed request for
SuzeShardlow
|
Thanks @ade1705, we'll review this! In the meantime, if you're a member of our Discord server (https://discord.gg/redis), please let us know your handle. Thanks! |
Yea, I am a member of the discord, my handle |
Added example scripts for the hyperloglog as requested - #2285
created a hyperloglog.js file
Checklist
npm testpass with this change (including linting)?