Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support timeseries multiple labels with same key #2677

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luasenvy
Copy link

Description

purpose:
support timeseries array labels

problem:
currently client.ts.create() is allow LABELS options for only { [key: string]: string }.
so, cannot use multiple label with same key like:

TS.CREATE MyKey labels hashtag=helloworld hashtag=ineed hashtag=multiple hashtag=labels

solve:
this PR is allow Array<string> too.

const LABELS = {
  hashtag: ['helloworld', 'ineed', 'multiple', 'labels'],
  someother: 'mykey'
}
await client.ts.create('MyKey', { LABELS })

I couldn't find any related issues. sorry for my search availity.

I think this feature will help make the code better.


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@luasenvy luasenvy changed the title support timeseries array labels support timeseries multiple labels with same key Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant