New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default reconnect strategy uses exponential backoff and jitter #2736
Open
qsymmachus
wants to merge
5
commits into
redis:v5
Choose a base branch
from
qsymmachus:backoff-reconnect-strategy
base: v5
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6ce28e5
Default reconnect strategy uses exponential backoff and jitter
qsymmachus 9d80ab9
Merge branch 'v5' into backoff-reconnect-strategy
qsymmachus 4a36c6f
Move default retry strategy to constant
qsymmachus 38eb603
Plain english explanation of default 'socket.reconnectStrategy'
qsymmachus e7304ad
Extract default connect strategy into helper function
qsymmachus File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,6 +82,15 @@ export default class RedisSocket extends EventEmitter { | |
} | ||
|
||
#createReconnectStrategy(options?: RedisSocketOptions): ReconnectStrategyFunction { | ||
const defaultStrategy = (retries: number) => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this should be moved to a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done in e7304ad 👍 |
||
// Generate a random jitter between 0 – 200 ms: | ||
const jitter = Math.floor(Math.random() * 200); | ||
// Delay is an exponential back off, (times^2) * 50 ms, with a maximum value of 2000 ms: | ||
const delay = Math.min(Math.pow(2, retries) * 50, 2000); | ||
|
||
return delay + jitter; | ||
} | ||
|
||
const strategy = options?.reconnectStrategy; | ||
if (strategy === false || typeof strategy === 'number') { | ||
return () => strategy; | ||
|
@@ -97,12 +106,12 @@ export default class RedisSocket extends EventEmitter { | |
return retryIn; | ||
} catch (err) { | ||
this.emit('error', err); | ||
return Math.min(retries * 50, 500); | ||
return defaultStrategy(retries); | ||
} | ||
}; | ||
} | ||
|
||
return retries => Math.min(retries * 50, 500); | ||
return defaultStrategy; | ||
} | ||
|
||
#createSocketFactory(options?: RedisSocketOptions) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the
^
operator is "Bitwise XOR" in JavaScript, not power.. we need to find a better way to document this..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with a plain English explanation of the strategy in 38eb603, rather than try to figure out how to pseudo-code this in a legible way.