Fix MEMORY USAGE key in cluster (legacy redis)
#3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…USAGE so that the Cluster can determine the correct node to query
eoghanmurray
changed the title
MEMORY USAGE key in clusterMEMORY USAGE key in cluster (legacy redis)
|
Ah I see the COMMAND return values in latest redis returns lots of subcommand info ... I'll leave it up to the maintainers to determine whether this sort of thing is worth backporting; my implementation is added as a fallback so shouldn't interfere with new information coming in from Redis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hard code determining that there is a single key argument for MEMORY USAGE so that the Cluster can determine the correct node to query
Tested against redis 5.0.3, so maybe the newer redis servers have better info in the COMMAND return values