Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scan iter command issued to different replicas #3220

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

agnesnatasya
Copy link

@agnesnatasya agnesnatasya commented Apr 30, 2024

Pull Request check-list

  • Do tests and lints pass with this change?
    • lint passes
    • test passes on Ubuntu 22.04, python3.11.2
Starting Redis tests
= 2352 passed, 1235 skipped, 849 deselected, 29 xpassed, 347 warnings in 163.65s (0:02:43) =
Waiting for 6 cluster nodes to become available
All nodes are available!
= 1571 passed, 1494 skipped, 1396 deselected, 4 xpassed, 244 warnings in 728.56s (0:12:08) =
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)? all succeeded in my fork.
  • Is the new or changed code fully tested? added tests coverage
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? bugfix only
    • I added some docstring to redis.asyncio.sentinel module. I wanted to check if the rST syntax is correct, but this module is not included in the builddir's index, so I think it's no-op.
  • Is there an example added to the examples folder (if applicable)? bugfix only
  • Was the change added to CHANGES file? bugfix only

fix scan iter command issued to different replicas

Fixes #3197. See linked issue for full description of the bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scan_iter family commands gives inconsistent result when using Sentinel connection pool
1 participant