Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: tweaks to make public build dockerfile portable between fedora/ubuntu distros #18301

Conversation

ivotron
Copy link
Member

@ivotron ivotron commented May 8, 2024

Changes to make public cpp toolchain dockerfile image portable on ubuntu and fedora

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.1.x
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@ivotron ivotron force-pushed the parameterize-docker-public-cpp-toolchain-image branch 3 times, most recently from 9dbab57 to dbf25b9 Compare May 8, 2024 20:20
@ivotron ivotron changed the title [WIP] tools: parameterize public cpp toolchain img tools: tweaks to make public build dockerfile portable between fedora/ubuntu distros May 8, 2024
@ivotron ivotron force-pushed the parameterize-docker-public-cpp-toolchain-image branch from dbf25b9 to 323c608 Compare May 8, 2024 23:39
@ivotron ivotron marked this pull request as ready for review May 8, 2024 23:39
@ivotron ivotron requested a review from a team as a code owner May 8, 2024 23:39
@ivotron ivotron requested review from savex and removed request for a team May 8, 2024 23:39
@ivotron ivotron force-pushed the parameterize-docker-public-cpp-toolchain-image branch from f4cd1f3 to c8f2ddd Compare May 13, 2024 22:58
check for `CLEAN_PKG_CACHE` variable before exiting, and if `true`
invoke the distro-specific way of cleaning the package cache. This is
useful when the `install-dependencies.sh` script is used to build docker
images

Signed-off-by: Ivo Jimenez <ivo@redpanda.com>
Signed-off-by: Ivo Jimenez <ivo@redpanda.com>
@ivotron ivotron force-pushed the parameterize-docker-public-cpp-toolchain-image branch from c8f2ddd to 4963276 Compare May 15, 2024 02:53
Copy link
Contributor

@savex savex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ivotron ivotron merged commit bd81a79 into redpanda-data:dev May 15, 2024
16 checks passed
@ivotron ivotron deleted the parameterize-docker-public-cpp-toolchain-image branch May 15, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants