Wrap certain wasm32-wasi ABI unsafe calls in unsafe to fix the build.
#18307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I modified the PR to mark the ABI stubs as unsafe, otherwise the Rust compiler will warn about unnecessary |
voutilad
changed the title
wasm32-wasi ABI unsafe calls in unsafe to fix the build.wasm32-wasi ABI unsafe calls in unsafe to fix the build.
rockwotj
approved these changes
May 11, 2024
|
Should probably prioritize an integration test for SR + Rust: |
@oleiman -> can you file an issue for this please? Thanks |
michael-redpanda
approved these changes
May 14, 2024
Yup, will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Required
Release Notes
n/a
Bug Fixes
sr-syscrate forwasm32-wasitargetFeatures
n/a
Improvements
n/a