tests/random: futurize make_random_batches #18388
Conversation
|
/ci-repeat 5 debug |
|
new failures in https://buildkite.com/redpanda/redpanda/builds/48914#018f60be-5152-456d-9a4e-885a0db547d2: new failures in https://buildkite.com/redpanda/redpanda/builds/48914#018f60be-5149-41f1-a123-9f1b3a093f8b: new failures in https://buildkite.com/redpanda/redpanda/builds/49063#018f756c-19c9-48ef-ab60-b5c54e8e89b2: |
|
/ci-repeat 1 debug |
1 similar comment
|
/ci-repeat 1 debug |
|
/ci-repeat 1 |
src/v/model/tests/random_batch.cc
Outdated
| @@ -273,7 +274,7 @@ make_random_memory_record_batch_reader(record_batch_spec spec, int n_batches) { | |||
| if (n_batches--) { | |||
| auto batch_spec = spec; | |||
| batch_spec.offset = offset; | |||
| batches = make_random_batches(batch_spec); | |||
| batches = make_random_batches(batch_spec).get(); | |||
There was a problem hiding this comment.
i think this should not use get() as it is not guaranteed that this will be called in the context of seastar thread
There was a problem hiding this comment.
looks like this is not used anywhere, I removed it for now.
| if (i % 5 == 0) { | ||
| co_await ss::coroutine::maybe_yield(); | ||
| } |
There was a problem hiding this comment.
should we also yield in the other overload of make_random_batches ?
no logic changes, futurizes it and updates all call sites
|
/ci-repeat 1 |
|
Failure unrelated #16474 |
Yield periodically to ensure that when replicating large payloads (with lots of batches), reactor is not stalled. Adds some additional debug logging in raft fixture that attempts leader retries.
(probably) fixes #18329
Backports Required
Release Notes