New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to new React Context API #4289
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4289 +/- ##
========================================
Coverage 100% 100%
========================================
Files 73 18 -55
Lines 1676 554 -1122
========================================
- Hits 1676 554 -1122
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #4289 +/- ##
======================================
Coverage 100% 100%
======================================
Files 73 74 +1
Lines 1676 1668 -8
======================================
- Hits 1676 1668 -8
Continue to review full report at Codecov.
|
Is this done? Or will it be released in a new version of redux-form when it is? Excited to try redux 6.0.0 but I rely heavily on redux-form. Thanks for the hard work! |
Going for a walk to clear my head before publishing. Expect it later today... |
Amazing, thank you! 😄 |
Wow @erikras - nice work. |
Published as |
const { forwardedRef, ...rest } = this.props | ||
return React.createElement(ReduxFormContext.Consumer, { | ||
children: _reduxForm => | ||
React.createElement(Component, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erikras Possible optimization: if the Component is a functional component (typeof Component === 'function'
) this could drop the createElement
call, just call the function directly with the props and thereby shorten the React tree by 1 component?
@erikras am having an issue with version 7. It is failing with the error: Please what could the problem be? |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Closes #4216