Fixed initialization and reinitialization #4599
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zation according to tests
…nge values with keepValues
Codecov Report
@@ Coverage Diff @@
## master #4599 +/- ##
==========================================
+ Coverage 99.42% 99.42% +<.01%
==========================================
Files 74 74
Lines 1745 1749 +4
==========================================
+ Hits 1735 1739 +4
Misses 10 10
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. #4020 provided a wrong fix, initialization and reinitialization is broken today. It is easy to fix it by refactoring
connectorandinitIfNeeded. I've tried to keep the same terminology, so refactoring should be obvious for project developers.Fixes #4069 and #4020.