-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potential hot destroy fix #947
Conversation
I'm gonna merge this, but I might roll it back if @gaearon tells me it's a terrible idea. |
This is a bit weird. Why is this necessary? React Hot Loader 3 shouldn’t unmount your components. |
Happening with |
I would say this should be reverted. If there is an issue with RHL, please file it in the RHL repo so I don’t forget to take a look. |
|
I guess I'm not seeing any other "hot" stuff in the example that demonstrates this, which I copied from one of your simpler examples not so long ago. Do you see something in there that's deprecated? |
Maybe it's this bit that needs modernizing? |
Oh, I see what you mean now. I didn’t realize you were using vanilla HMR API. With vanilla HMR, it’s expected that components get unmounted on change. So if Redux Form destroys on unmount, everything behaves as expected. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hey, @gaearon, is a reasonable for a library to examine
module.hot
? This fixes #623.