-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Named export createSagaMiddleware added to @redux-saga/core #2399
base: main
Are you sure you want to change the base?
Conversation
|
I'd like to review the upstream issue first - before landing this - because I think this should not be necessary and I want to know what's happening. I'll try to take a look at this some time next week - but feel free to ping me if I forget. |
@Andarist there is some new details about the problem |
The resolution I'd like to take here is to migrate our build setup to https://github.com/preconstruct/preconstruct/ . I have part of the work done on some old branch but never got to finishing it. I believe that would resolve the issue since it would output dist files in a way that they would be compatible with a wide range of tools |
@Andarist thanks a lot, but can you also add named export for createSagaMiddleware? |
Can we take babysteps and merge this PR first? Its causing quite a bit of headache on rollup, side of things:
for cjs gets translated into:
which lacks the A named export would be very handy, expecially with the VSCode's auto-import plugins which don't work with default exports. |
@cristian-eriomenco I would also really like to add named exports, it is convenient and will help solve build problems in our case |
@shaunvdberg @cristian-eriomenco @Andarist I still think the fastest and easiest solution would be to add a named export of |
createSagaMiddleware
added to@redux-saga/core
According to #2396