Skip to content

Commit

Permalink
Remove no-resolution flag when running are-the-types-wrong during CI
Browse files Browse the repository at this point in the history
  - `@arethetypeswrong/cli` now has an `--exclude-entrypoints` flag which we can use to exclude the `alternate-renderers` entrypoint from the check since it will fail under the `Node10` module resolution as `Node10` looks at actual files on disk and we don't have a file named `alternate-renderers`.
  • Loading branch information
aryaemami59 committed Apr 7, 2024
1 parent 098f862 commit d083422
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/test.yml
Expand Up @@ -93,10 +93,8 @@ jobs:
path: .

# Note: We currently expect "FalseCJS" failures for Node16 + `moduleResolution: "node16",
# and the `/alternateRenderers" entry point will not resolve under Node10.
# Skipping these is dangerous, but we'll leave it for now.
- name: Run are-the-types-wrong
run: npx @arethetypeswrong/cli ./package.tgz --format table --ignore-rules false-cjs no-resolution
run: npx @arethetypeswrong/cli ./package.tgz --format table --ignore-rules false-cjs --exclude-entrypoints alternate-renderers

test-published-artifact:
name: Test Published Artifact ${{ matrix.example }}
Expand Down

0 comments on commit d083422

Please sign in to comment.