Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor optimization: remove conditional #1131

Merged
merged 2 commits into from Dec 14, 2018
Merged

Minor optimization: remove conditional #1131

merged 2 commits into from Dec 14, 2018

Commits on Dec 14, 2018

  1. Minor optimization: remove conditional 

    The conditional in selectDerivedProps is unnecessary. The code behaves
identically now but saves about 10% of performance for that portion of
the function.

See: https://jsperf.com/conditional-vs-not

Code left in place but commented in case someone ever wants to add
something like it back for "clarity".
    @ericanderson
    ericanderson committed Dec 14, 2018
    Copy the full SHA
    7e2a134 View commit details
    Browse the repository at this point in the history

  2. Just remove the code

    @timdorr
    timdorr committed Dec 14, 2018
    Copy the full SHA
    7da8c0d View commit details
    Browse the repository at this point in the history