Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that component prop 'context' really contains a React context … #1134

Merged
merged 10 commits into from Jan 8, 2019

Commits on Dec 17, 2018

  1. Ensure that component prop 'context' really contains a React context …

    …before using it
    
    after switching to react-redux 6.0.0, we've had a lot of errors stating
    
    Warning: React.createElement: type is invalid -- expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.
    
    all over in our app. After digging deeper, we've discovered that we use a lot of (connected) components using a property named 'context' which conflicts with your new connectAdvanced code. So maybe you can improve the check on this.props.context a little bit to ensure it is used only if it really contains a valid React context.
    casdevs committed Dec 17, 2018
    Copy the full SHA
    2c8fa0c View commit details
    Browse the repository at this point in the history
  2. Update connectAdvanced.js

    casdevs committed Dec 17, 2018
    Copy the full SHA
    0d79a85 View commit details
    Browse the repository at this point in the history
  3. Update connectAdvanced.js

    casdevs committed Dec 17, 2018
    Copy the full SHA
    c046ae6 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    9f1edde View commit details
    Browse the repository at this point in the history
  5. added test for ignoring non-react-context values passed as a prop to …

    …the component
    stefan.hausmann committed Dec 17, 2018
    Copy the full SHA
    5befe04 View commit details
    Browse the repository at this point in the history
  6. Use react-is checks

    timdorr committed Dec 17, 2018
    Copy the full SHA
    f4262b8 View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    6f72646 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2019

  1. improved check for context.Consumer

    stefan.hausmann committed Jan 8, 2019
    Copy the full SHA
    59ff826 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'patch-1' of https://github.com/casdevs/react-redux into…

    … patch-1
    stefan.hausmann committed Jan 8, 2019
    Copy the full SHA
    9c9e002 View commit details
    Browse the repository at this point in the history
  3. added missing export 'isContextConsumer' in rollup config

    stefan.hausmann committed Jan 8, 2019
    Copy the full SHA
    50fd894 View commit details
    Browse the repository at this point in the history