Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't re-run the selector after update #1701

Merged
merged 2 commits into from Mar 25, 2021
Merged

Don't re-run the selector after update #1701

merged 2 commits into from Mar 25, 2021

Commits on Mar 25, 2021

  1. Don't re-run the selector after update 

    Fixes #1697

We can avoid running the selector twice by setting the latestStoreState at the same time as setting the latestSelectedState. If the store state hasn't changed, then the selector won't as well (since it's pure).
    @timdorr
    timdorr committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    3146b35 View commit details
    Browse the repository at this point in the history

  2. Avoid variable naming conflicts

    @timdorr
    timdorr committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    b92a139 View commit details
    Browse the repository at this point in the history